[webkit-changes] [WebKit/WebKit] 7707bd: [IFC] Available space on main axis computation sho...

Alan Baradlay noreply at github.com
Sun Jul 16 20:43:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7707bd0020f85ef8ab11f353f64b963d5f59f92e
      https://github.com/WebKit/WebKit/commit/7707bd0020f85ef8ab11f353f64b963d5f59f92e
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-07-16 (Sun, 16 Jul 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp

  Log Message:
  -----------
  [IFC] Available space on main axis computation should use "main size"
https://bugs.webkit.org/show_bug.cgi?id=259256

Reviewed by Antti Koivisto.

Inside this loop the available size changes as we start "freezing" flex items. In order to compute the available size properly
we need to use the adjusted (shrunk/grown) main size values.
(Also 3 drive-by fixes on various issues)

* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::computeMainSizeForFlexItems const):

Canonical link: https://commits.webkit.org/266094@main




More information about the webkit-changes mailing list