[webkit-changes] [WebKit/WebKit] b41af4: Setting outerHTML on child of DocumentFragment sho...

Ahmad Saleem noreply at github.com
Sat Jul 15 15:07:01 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b41af45ee409c4445f2ffa18ee14959c044b083e
      https://github.com/WebKit/WebKit/commit/b41af45ee409c4445f2ffa18ee14959c044b083e
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-07-15 (Sat, 15 Jul 2023)

  Changed paths:
    M LayoutTests/fast/dom/set-outer-html-special-cases-expected.txt
    M LayoutTests/fast/dom/set-outer-html-special-cases.html
    M LayoutTests/fast/dynamic/outerHTML-no-element-expected.txt
    M LayoutTests/fast/dynamic/outerHTML-no-element.html
    M Source/WebCore/dom/Element.cpp

  Log Message:
  -----------
  Setting outerHTML on child of DocumentFragment should not throw error

https://bugs.webkit.org/show_bug.cgi?id=249737
rdar://problem/103746193

Reviewed by Chris Dumez.

This patch aligns WebKit with Gecko / Firefox and Web-Spec [1].

In 238774 at main, WebKit aligned with behavior for better compatibility but
it was not correct and clarified later to not throw error [2]. This PR is
essentially revert part of 238774 at main with update to align by not throwing error.

[1] https://w3c.github.io/DOM-Parsing/#dom-element-outerhtml
[2] https://github.com/whatwg/html/issues/8657

* Source/WebCore/dom/Element.cpp:
(Element::setOuterHTML): Update to not throw error
* LayoutTests/fast/dynamic/outerHTML-no-element.html: Rebaselined
* LayoutTests/fast/dynamic/outerHTML-no-element-expected.txt: Rebaselined
* LayoutTests/fast/dom/set-outer-html-special-cases.html: Rebaselined
* LayoutTests/fast/dom/set-outer-html-special-cases-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/266086@main




More information about the webkit-changes mailing list