[webkit-changes] [WebKit/WebKit] e1dd61: Consume transient activation more directly after s...

Brady Eidson noreply at github.com
Fri Jul 14 14:22:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e1dd6130c21b5814b4bfbc3230405c9af165d965
      https://github.com/WebKit/WebKit/commit/e1dd6130c21b5814b4bfbc3230405c9af165d965
  Author: Brady Eidson <beidson at apple.com>
  Date:   2023-07-14 (Fri, 14 Jul 2023)

  Changed paths:
    M Source/WebCore/bindings/js/ScriptController.cpp
    M Source/WebCore/page/LocalDOMWindow.cpp
    M Source/WebCore/page/LocalDOMWindow.h

  Log Message:
  -----------
  Consume transient activation more directly after script runs
https://bugs.webkit.org/show_bug.cgi?id=259224
rdar://112122350

Reviewed by Chris Dumez.

Old code walked the frame tree of each impacted document, which was unecessary.
Let's just directly set the transient activation timestamp for any remaining impacted documents.

* Source/WebCore/bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeScriptInWorld):

* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::consumeTransientActivation):
(WebCore::LocalDOMWindow::consumeLastActivationIfNecessary):
* Source/WebCore/page/LocalDOMWindow.h:

Canonical link: https://commits.webkit.org/266072@main




More information about the webkit-changes mailing list