[webkit-changes] [WebKit/WebKit] 4cc63d: REGRESSION: source code viewer on Github renders t...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4cc63dfc70a9df30e97dfd5753f8cdad28f96301
      https://github.com/WebKit/WebKit/commit/4cc63dfc70a9df30e97dfd5753f8cdad28f96301
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-07-14 (Fri, 14 Jul 2023)

  Changed paths:
    M LayoutTests/fast/css/caret-color-auto-expected.html
    M LayoutTests/fast/css/caret-color-auto.html
    A LayoutTests/fast/css/caret-color-with-inherited-color-property-expected.html
    A LayoutTests/fast/css/caret-color-with-inherited-color-property.html
    A LayoutTests/fast/css/caret-color-with-initial-color-property-expected.html
    A LayoutTests/fast/css/caret-color-with-initial-color-property.html
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/editing/FrameSelection.cpp
    M Source/WebCore/editing/FrameSelection.h
    M Source/WebCore/rendering/RenderThemeIOS.mm
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/rendering/style/RenderStyleSetters.h
    M Source/WebCore/style/StyleBuilderCustom.h
    M Source/WebCore/style/StyleBuilderState.h
    M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
    M Source/WebKitLegacy/mac/WebView/WebFrame.mm

  Log Message:
  -----------
  REGRESSION: source code viewer on Github renders two overlapping carets
https://bugs.webkit.org/show_bug.cgi?id=259166
rdar://112056259

Reviewed by Aditya Keerthi.

The color of the caret should respect both the `caret-color` and the `color` properties.
Because every element implicitly has a `color`, the color of the caret should only reflect
this property if set by the author.

* LayoutTests/fast/css/caret-color-with-color-property-expected.html: Added.
* LayoutTests/fast/css/caret-color-with-color-property.html: Added.
* LayoutTests/fast/css/caret-color-with-inherited-color-property-expected.html: Added.
* LayoutTests/fast/css/caret-color-with-inherited-color-property.html: Added.
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::CaretBase::computeCaretColor):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::hasExplicitlySetColor const):
(WebCore::RenderStyle::InheritedFlags::operator== const):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setHasExplicitlySetColor):
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueColor):
(WebCore::Style::BuilderCustom::applyInitialColor):
* Source/WebCore/style/StyleBuilderState.h:
(WebCore::Style::BuilderState::isAuthorOrigin const):

Canonical link: https://commits.webkit.org/266070@main