[webkit-changes] [WebKit/WebKit] 37352d: WASM sources should use more specific macros than ...

Ross Kirsling noreply at github.com
Fri Jul 14 01:55:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37352d2348e7717a4de489470019968596806367
      https://github.com/WebKit/WebKit/commit/37352d2348e7717a4de489470019968596806367
  Author: Ross Kirsling <rkirsling at gmail.com>
  Date:   2023-07-14 (Fri, 14 Jul 2023)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp
    M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp

  Log Message:
  -----------
  WASM sources should use more specific macros than FINALIZE_CODE()
https://bugs.webkit.org/show_bug.cgi?id=259208

Reviewed by Yusuke Suzuki.

FINALIZE_WASM_CODE() and FINALIZE_WASM_CODE_FOR_MODE() exist, so we should use them instead of just FINALIZE_CODE();
otherwise, dumpWasmDisassembly is missing information that you'd expect it to have.

* Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:
(JSC::Wasm::BBQPlan::didCompleteCompilation):
* Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp:
(JSC::Wasm::LLIntPlan::didCompleteCompilation):

Canonical link: https://commits.webkit.org/266062@main




More information about the webkit-changes mailing list