[webkit-changes] [WebKit/WebKit] c7ca29: AR View closes instead of showing 3D asset - Mobil...

[Dean Jackson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7ca29832dcbf36dc2c8ee92f42b7c3aae2abf9e
      https://github.com/WebKit/WebKit/commit/c7ca29832dcbf36dc2c8ee92f42b7c3aae2abf9e
  Author: Dean Jackson <dino at apple.com>
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/system-preview.html

  Log Message:
  -----------
  AR View closes instead of showing 3D asset - MobileSafari Crashing at -[_WKSystemPreviewDataTaskDelegate dataTask:didCompleteWithError:] + 32
https://bugs.webkit.org/show_bug.cgi?id=258957
rdar://110671973

Reviewed by Tim Horton.

When we try to load a `blob:` URL, the WKDataTask instantly fails. This
causes us to try to close a file handle that hasn't been initialised.
Add a check to make sure that doesn't happen.

There is still the bigger bug of needing to actually load blob URLs.

* Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/system-preview.html:

Canonical link: https://commits.webkit.org/266048@main