[webkit-changes] [WebKit/WebKit] b2ea0a: AX: The Pause All Animations and Play All Animatio...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b2ea0a1f6950f394f806985b0336521d0b9daacd
      https://github.com/WebKit/WebKit/commit/b2ea0a1f6950f394f806985b0336521d0b9daacd
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
    M Source/WebCore/page/ContextMenuController.cpp

  Log Message:
  -----------
  AX: The Pause All Animations and Play All Animations context menu items appear too high in the list
https://bugs.webkit.org/show_bug.cgi?id=259158
rdar://111593440

Reviewed by Andres Gonzalez.

Typically, context menu items are ordered such that the things most
relevant to the target are first, with "global" items coming after.
For example, if I activate the context menu on a link, I expect
"Copy Link" to be at the top of the list.

Due to the location where PauseAllAnimations and PlayAllAnimations
context menu items are added in ContextMenuController::populate, they
are often too high in the list, sometimes appearing above these more
relevant actions.

With this patch, these items are now grouped with the PauseAnimation and
PlayAnimation context menu items if they are present, and placed at the
bottom of the list otherwise, better matching user expectation.

* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):

Canonical link: https://commits.webkit.org/266037@main