[webkit-changes] [WebKit/WebKit] 593a55: REGRESSION(265827 at main): Logical properties fail t...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 593a553fd1eb21d0d8c8da49abb46d175144c6e0
      https://github.com/WebKit/WebKit/commit/593a553fd1eb21d0d8c8da49abb46d175144c6e0
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
    A LayoutTests/fast/css/variables/variable-reference-override-deferred-cached-expected.html
    A LayoutTests/fast/css/variables/variable-reference-override-deferred-cached.html
    M Source/WebCore/style/PropertyCascade.cpp

  Log Message:
  -----------
  REGRESSION(265827 at main): Logical properties fail to override physical properties with variable references
https://bugs.webkit.org/show_bug.cgi?id=259186
rdar://112194939

Reviewed by Simon Fraser.

The code assumes that only values set later on the same property can override a variable reference.
This is not true in case properties with separate physical and logical versions

* LayoutTests/fast/css/variables/variable-reference-override-deferred-cached-expected.html: Added.
* LayoutTests/fast/css/variables/variable-reference-override-deferred-cached.html: Added.
* Source/WebCore/style/PropertyCascade.cpp:
(WebCore::Style::PropertyCascade::addMatch):

If we have seen any variable references overriding deferred properties start applying all subsequent
deferred properties.

Canonical link: https://commits.webkit.org/266033@main