[webkit-changes] [WebKit/WebKit] a64778: Guard MatchedDeclarationsCache against destruction...

Chris Dumez noreply at github.com
Wed Jul 12 12:43:13 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a64778e92200eb9030afd753c803f5623eead6f5
      https://github.com/WebKit/WebKit/commit/a64778e92200eb9030afd753c803f5623eead6f5
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-07-12 (Wed, 12 Jul 2023)

  Changed paths:
    M Source/WebCore/style/MatchedDeclarationsCache.cpp
    M Source/WebCore/style/MatchedDeclarationsCache.h
    M Source/WebCore/style/StyleResolver.cpp
    M Source/WebCore/style/StyleResolver.h

  Log Message:
  -----------
  Guard MatchedDeclarationsCache against destruction while modifying m_entries map
https://bugs.webkit.org/show_bug.cgi?id=259147
rdar://107338197

Reviewed by Antti Koivisto.

Guard MatchedDeclarationsCache against destruction while modifying m_entries map.
We suspect that MatchedDeclarationsCache is getting destroyed while modifying
m_entries inside sweep().

* Source/WebCore/style/MatchedDeclarationsCache.cpp:
(WebCore::Style::MatchedDeclarationsCache::MatchedDeclarationsCache):
(WebCore::Style::MatchedDeclarationsCache::ref):
(WebCore::Style::MatchedDeclarationsCache::deref):
(WebCore::Style::MatchedDeclarationsCache::clearEntriesAffectedByViewportUnits):
(WebCore::Style::MatchedDeclarationsCache::sweep):
* Source/WebCore/style/MatchedDeclarationsCache.h:
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::Resolver):
* Source/WebCore/style/StyleResolver.h:

Canonical link: https://commits.webkit.org/265998@main




More information about the webkit-changes mailing list