[webkit-changes] [WebKit/WebKit] a17521: AX: AXCoreObject::enumerateDescendants is missing ...

Tyler Wilcock noreply at github.com
Wed Jul 12 05:07:38 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a17521aaa41390048d8bc2d42352bc57ed76460d
      https://github.com/WebKit/WebKit/commit/a17521aaa41390048d8bc2d42352bc57ed76460d
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-07-12 (Wed, 12 Jul 2023)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityObjectInterface.h

  Log Message:
  -----------
  AX: AXCoreObject::enumerateDescendants is missing a null check on object children
https://bugs.webkit.org/show_bug.cgi?id=259138
rdar://100626906

Reviewed by Chris Fleizach.

Prevent nullptr crashes by checking that each child from
AXCoreObject::children() is not null in AXCoreObject::enumerateDescendants.

In a future patch, we should make `AccessibilityChildrenVector` be a Vector of `Ref`s
rather than a Vector of `RefPtr`s as it is today. RefPtr does not make sense for this
type -- either we have a child or we don't.

* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
(WebCore::Accessibility::enumerateDescendants):

Canonical link: https://commits.webkit.org/265992@main




More information about the webkit-changes mailing list