[webkit-changes] [WebKit/WebKit] 36e066: Attachment: Correct display of RTL labels
Gerald Squelart
noreply at github.com
Wed Jul 12 04:12:57 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 36e066b5f3e20eaa6fe432d0220e45a96c7ad129
https://github.com/WebKit/WebKit/commit/36e066b5f3e20eaa6fe432d0220e45a96c7ad129
Author: Gerald Squelart <g_squelart at apple.com>
Date: 2023-07-12 (Wed, 12 Jul 2023)
Changed paths:
M Source/WebCore/html/HTMLAttachmentElement.cpp
Log Message:
-----------
Attachment: Correct display of RTL labels
https://bugs.webkit.org/show_bug.cgi?id=259027
rdar://108566229
Reviewed by Alan Baradlay.
To let the shadow DOM CSS correctly align and cut too-long labels, the elements need to have a `dir="auto"`
attribute, and titles with RTL filenames should add an outer right-to-left mark so that the automatic
direction works as expected.
* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::ensureWideLayoutShadowTree):
(WebCore::HTMLAttachmentElement::attachmentTitleForDisplay const):
Canonical link: https://commits.webkit.org/265989@main
More information about the webkit-changes
mailing list