[webkit-changes] [WebKit/WebKit] f43f81: RemoteInspectorSocketWin.cpp: warning: cast from '...

Fujii Hironori noreply at github.com
Tue Jul 11 21:32:23 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f43f814b129e0da721ae11915c42e4e73d3607a1
      https://github.com/WebKit/WebKit/commit/f43f814b129e0da721ae11915c42e4e73d3607a1
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-07-11 (Tue, 11 Jul 2023)

  Changed paths:
    M Source/JavaScriptCore/inspector/remote/socket/win/RemoteInspectorSocketWin.cpp

  Log Message:
  -----------
  RemoteInspectorSocketWin.cpp: warning: cast from 'struct sockaddr *' to 'struct sockaddr_in *' increases required alignment from 2 to 4
https://bugs.webkit.org/show_bug.cgi?id=259096

Reviewed by Ross Kirsling.

clang-cl reported the following warning for Windows port.

> JavaScriptCore\inspector\remote\socket\win\RemoteInspectorSocketWin.cpp(172,33): warning: cast from 'struct sockaddr *' to 'struct sockaddr_in *' increases required alignment from 2 to 4 [-Wcast-align]
>             address.sin_addr = ((struct sockaddr_in*)(res->ai_addr))->sin_addr;
>                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

* Source/JavaScriptCore/inspector/remote/socket/win/RemoteInspectorSocketWin.cpp:
(Inspector::Socket::connect): Use reinterpret_cast instead of C style cast to suppress the warning.

Canonical link: https://commits.webkit.org/265984@main




More information about the webkit-changes mailing list