[webkit-changes] [WebKit/WebKit] 775854: Begin implementing redirect handling for site-isol...

Alex Christensen noreply at github.com
Tue Jul 11 20:44:44 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77585442bf6a0acc7af584f838acd4653918b7e9
      https://github.com/WebKit/WebKit/commit/77585442bf6a0acc7af584f838acd4653918b7e9
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-07-11 (Tue, 11 Jul 2023)

  Changed paths:
    M Source/WebKit/Shared/LocalFrameCreationParameters.h
    M Source/WebKit/Shared/LocalFrameCreationParameters.serialization.in
    M Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp
    M Source/WebKit/UIProcess/ProvisionalFrameProxy.h
    M Source/WebKit/UIProcess/WebFrameProxy.cpp
    M Source/WebKit/UIProcess/WebFrameProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  Begin implementing redirect handling for site-isolation
https://bugs.webkit.org/show_bug.cgi?id=259133
rdar://112109909

Reviewed by J Pascoe.

When a same-site redirect was received when navigating an iframe, we would
resend the TransitionToLocal message causing an assertion.  This message is
not needed if there is already a local frame in the process.

I also moved a lot of the process preparation code from ProvisionalFrameProxy's
constructor and WebPageProxy to a new-ish function prepareForProvisionalNavigationInProcess
which is just expanding what used to be called "swapToProcess" to handle more cases.

* Source/WebKit/Shared/LocalFrameCreationParameters.h:
* Source/WebKit/Shared/LocalFrameCreationParameters.serialization.in:
* Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp:
(WebKit::ProvisionalFrameProxy::ProvisionalFrameProxy):
(WebKit::ProvisionalFrameProxy::~ProvisionalFrameProxy):
* Source/WebKit/UIProcess/ProvisionalFrameProxy.h:
* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::prepareForProvisionalNavigationInProcess):
(WebKit::WebFrameProxy::swapToProcess): Deleted.
* Source/WebKit/UIProcess/WebFrameProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::continueNavigationInNewProcess):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/265982@main




More information about the webkit-changes mailing list