[webkit-changes] [WebKit/WebKit] 62ac85: Fix WasmFaultSignalHandler.cpp doesn't compile on ...

Linda_pp noreply at github.com
Tue Jul 11 13:32:27 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62ac852fe74f53bfa9e969af61d7da3a5d740134
      https://github.com/WebKit/WebKit/commit/62ac852fe74f53bfa9e969af61d7da3a5d740134
  Author: Hayashida Ryuichi <Ryuichi.Hayashida at sony.com>
  Date:   2023-07-11 (Tue, 11 Jul 2023)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp
    M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h
    M Source/WTF/wtf/threads/Signals.cpp

  Log Message:
  -----------
  Fix WasmFaultSignalHandler.cpp doesn't compile on Windows
https://bugs.webkit.org/show_bug.cgi?id=258556

Reviewed by Ross Kirsling.

WTF/wtf/threads/Signals.cpp assumes Unix platforms but
WasmFaultSignalHandler.cpp uses the signals API without checking the
platform.

This patch avoids setting the signal handlers not to use the signals
API so that it doesn't break Windows build.

This is a temporary fix. Signal handlers for WIndows are eventually
implemented at https://bugs.webkit.org/show_bug.cgi?id=259108

* Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp:
* Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h:

Canonical link: https://commits.webkit.org/265964@main




More information about the webkit-changes mailing list