[webkit-changes] [WebKit/WebKit] 8d6e88: (REGRESSION)[IFC] Content in nested inline boxes w...

Alan Baradlay noreply at github.com
Tue Jul 11 11:12:32 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8d6e889b958e37975bc78fa4a6f93c7e4096a6e3
      https://github.com/WebKit/WebKit/commit/8d6e889b958e37975bc78fa4a6f93c7e4096a6e3
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-07-11 (Tue, 11 Jul 2023)

  Changed paths:
    A LayoutTests/fast/inline/nested-inline-boxes-with-decoration-clone-expected.html
    A LayoutTests/fast/inline/nested-inline-boxes-with-decoration-clone.html
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  -----------
  (REGRESSION)[IFC] Content in nested inline boxes with decoration clone may overflow unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=259110

Reviewed by Antti Koivisto.

This code incorrectly assumed 0 as empty hash map value for float type (while it is inf).

It causes the available space grow infinite when not all (nested) inline-boxes have
the decoration-break property set (e.g. <span class=has_decoration_break><span>some content here</span></span>)
as the inner inline-box is not in the hashmap (and inlineBoxListWithClonedDecorationEnd.get() returns inf).

* LayoutTests/fast/inline/nested-inline-boxes-with-decoration-clone-expected.html: Added.
* LayoutTests/fast/inline/nested-inline-boxes-with-decoration-clone.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::availableWidth):

Canonical link: https://commits.webkit.org/265953@main




More information about the webkit-changes mailing list