[webkit-changes] [WebKit/WebKit] beecad: Keep attachment save icon size even with using lar...

Gerald Squelart noreply at github.com
Tue Jul 11 07:00:02 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: beecadc714145c68516ae171b97e4c7924ace7a0
      https://github.com/WebKit/WebKit/commit/beecadc714145c68516ae171b97e4c7924ace7a0
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2023-07-11 (Tue, 11 Jul 2023)

  Changed paths:
    M LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    M LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    M Source/WebCore/html/shadow/attachmentElementShadow.css

  Log Message:
  -----------
  Keep attachment save icon size even with using larger accessibility text
https://bugs.webkit.org/show_bug.cgi?id=259101
rdar://112060938

Reviewed by Tim Nguyen.

When larger text size is used, the default button CSS padding becomes enormous and squashed the save SVG
icon into nothing. This patch removes the excessive padding, and forces the expected icon size.

* LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* Source/WebCore/html/shadow/attachmentElementShadow.css:
(button#attachment-save-button):
(div#attachment-save-icon):

Canonical link: https://commits.webkit.org/265945@main




More information about the webkit-changes mailing list