[webkit-changes] [WebKit/WebKit] b6ffbb: Make <attachment> save button use a single element

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6ffbbe0a3549b00ce40a6cd9a4c8cc5996204a4
      https://github.com/WebKit/WebKit/commit/b6ffbbe0a3549b00ce40a6cd9a4c8cc5996204a4
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-07-10 (Mon, 10 Jul 2023)

  Changed paths:
    M LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    M LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    M Source/WebCore/html/HTMLAttachmentElement.cpp
    M Source/WebCore/html/shadow/attachmentElementShadow.css

  Log Message:
  -----------
  Make <attachment> save button use a single element
https://bugs.webkit.org/show_bug.cgi?id=259086
rdar://112047912

Reviewed by Aditya Keerthi.

Save a bit code by using a pseudo-element instead of another element.

* LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::updateSaveButton):
(WebCore::attachmentSaveIconIdentifier): Deleted.
* Source/WebCore/html/shadow/attachmentElementShadow.css:
(button#attachment-save-button::before):
(div#attachment-save-icon): Deleted.

Canonical link: https://commits.webkit.org/265934@main