[webkit-changes] [WebKit/WebKit] 80a97a: [JSC] Fix StrCat(ToPrimitive(x), ...) in attemptTo...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 80a97a5a3797380f436a4f76819caf1fca035d37
      https://github.com/WebKit/WebKit/commit/80a97a5a3797380f436a4f76819caf1fca035d37
  Author: Yijia Huang <yijia_huang at apple.com>
  Date:   2023-07-10 (Mon, 10 Jul 2023)

  Changed paths:
    A JSTests/stress/strcat-str-str-bigint.js
    M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp

  Log Message:
  -----------
  [JSC] Fix StrCat(ToPrimitive(x), ...) in attemptToMakeFastStringAdd
https://bugs.webkit.org/show_bug.cgi?id=259074
rdar://112016271

Reviewed by Yusuke Suzuki.

Previously, we introduced a fast path [1] for string catenation with
ToPrimitive. And the path doesn't need canOptimizeStringObjectAccess
to be true. This patch reorders the if checks in attemptToMakeFastStringAdd
to avoid canOptimizeStringObjectAccess assertion.

[1] https://commits.webkit.org/265636@main

* JSTests/stress/strcat-str-str-bigint.js: Added.
(foo):
* Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::attemptToMakeFastStringAdd):

Canonical link: https://commits.webkit.org/265927@main