[webkit-changes] [WebKit/WebKit] 6f928c: REGRESSION (262875 at main / iOS 17): fill: 'both' no...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f928cc543c3d8287b87fb3c38cf8ca4f5bc2829
      https://github.com/WebKit/WebKit/commit/6f928cc543c3d8287b87fb3c38cf8ca4f5bc2829
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-07-10 (Mon, 10 Jul 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-opacity-replaced-effect-in-shadow-root-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-opacity-replaced-effect-in-shadow-root-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-opacity-replaced-effect-in-shadow-root.html
    M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/animation/KeyframeEffectStack.cpp

  Log Message:
  -----------
  REGRESSION (262875 at main / iOS 17): fill: 'both' not respected with animation
https://bugs.webkit.org/show_bug.cgi?id=257861
rdar://111407099

Reviewed by Simon Fraser.

While we fixed a similar issue with 265498 at main, the fix was not complete. Indeed, to correctly
deal with accelerated replaced effects in an effect stack, we must ensure two things:

1. in `KeyframeEffect::applyPendingAcceleratedActionsOrUpdateTimingProperties()`, where we ensure
   the accelerated effect is present on the backing GraphicsLayerCA in the right sort order, we
   not only need to add an `UpdateProperties` accelerated action but also ensure that we mark it
   as running by setting the `m_lastRecordedAcceleratedAction` member.

2. in `KeyframeEffectStack::applyPendingAcceleratedActions()`, where we update all effects in the
   stack to ensure any pending accelerated actions as applied, we must *not* force the running of
   replaced effects if all the accelerated effects in the stack are *not* actively running. In that
   case we must only call `KeyframeEffect::applyPendingAcceleratedActions` to ensure any previously-running
   accelerated effect has a chance to be stopped.

* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-opacity-replaced-effect-in-shadow-root-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-opacity-replaced-effect-in-shadow-root-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-opacity-replaced-effect-in-shadow-root.html: Added.
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::applyPendingAcceleratedActionsOrUpdateTimingProperties):
* Source/WebCore/animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::applyPendingAcceleratedActions const):

Canonical link: https://commits.webkit.org/265909@main