[webkit-changes] [WebKit/WebKit] 8a7a67: [GStreamer] Avoid crash for unexisting pad in webk...

Xabier Rodríguez noreply at github.com
Mon Jul 10 06:22:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a7a67a6127b2d6813b60933c801aa14ed647713
      https://github.com/WebKit/WebKit/commit/8a7a67a6127b2d6813b60933c801aa14ed647713
  Author: Xabier Rodriguez-Calvar <calvaris at igalia.com>
  Date:   2023-07-10 (Mon, 10 Jul 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp

  Log Message:
  -----------
  [GStreamer] Avoid crash for unexisting pad in webkitGstTraceProcessingTimeForElement
https://bugs.webkit.org/show_bug.cgi?id=258986

Reviewed by Philippe Normand.

In some platforms srcPad can become null, hence crashing. Now it's protected.
We also avoid the cause of the crash in the first place.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::configureElement):
* Source/WebCore/platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp:
(webkitGstTraceProcessingTimeForElement):

Canonical link: https://commits.webkit.org/265902@main




More information about the webkit-changes mailing list