[webkit-changes] [WebKit/WebKit] c4d116: REGRESSION(265596 at main) Vertical WebVTT cues are l...

Jer Noble noreply at github.com
Fri Jul 7 13:04:34 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c4d1167df42e2c76331e86877e086fa64dead53a
      https://github.com/WebKit/WebKit/commit/c4d1167df42e2c76331e86877e086fa64dead53a
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-07-07 (Fri, 07 Jul 2023)

  Changed paths:
    A LayoutTests/media/track/track-cue-vertical-style-expected.txt
    A LayoutTests/media/track/track-cue-vertical-style.html
    M Source/WebCore/html/track/VTTCue.cpp

  Log Message:
  -----------
  REGRESSION(265596 at main) Vertical WebVTT cues are laid out horizontally
https://bugs.webkit.org/show_bug.cgi?id=258980
rdar://111909315

Reviewed by Eric Carlson.

Use the calculated value of `writing-mode` in applyCSSProperties() rather
than the default provided in the UA style sheet.

* LayoutTests/media/track/track-cue-vertical-style-expected.txt: Added.
* LayoutTests/media/track/track-cue-vertical-style.html: Added.
* Source/WebCore/html/track/VTTCue.cpp:
(WebCore::VTTCueBox::applyCSSProperties):

Canonical link: https://commits.webkit.org/265860@main




More information about the webkit-changes mailing list