[webkit-changes] [WebKit/WebKit] c9f844: Dictation glow can be rendered exceeding graphics ...

mwyrzykowski noreply at github.com
Fri Jul 7 10:08:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c9f844d07498207a3163fdae7793db9577cf1d98
      https://github.com/WebKit/WebKit/commit/c9f844d07498207a3163fdae7793db9577cf1d98
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-07-07 (Fri, 07 Jul 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp
    M Tools/TestWebKitAPI/Tests/WebCore/DisplayListRecorderTests.cpp

  Log Message:
  -----------
  Dictation glow can be rendered exceeding graphics context bounds
https://bugs.webkit.org/show_bug.cgi?id=258960
<radar://111867549>

Reviewed by Kimmo Kinnunen.

We should never set the clip rectangle to something larger than the
initial graphics context bounds, since we won't render to an area
larger than that and the contents will be left stale.

Correct this by clipping to the initial clip rectangle whenever the clip
rectangle is reset.

* Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::resetClip):
We were already setting the clip bounds to this value a few lines above.

* Tools/TestWebKitAPI/Tests/WebCore/DisplayListRecorderTests.cpp:
Update test expectation.

Canonical link: https://commits.webkit.org/265851@main




More information about the webkit-changes mailing list