[webkit-changes] [WebKit/WebKit] 1866a4: Do not convert testharness paths in import-w3c-tests

Chris Nardi noreply at github.com
Fri Jul 7 07:44:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1866a4e1cf4833ce8cfa2b7bc36e14d5c7dc0273
      https://github.com/WebKit/WebKit/commit/1866a4e1cf4833ce8cfa2b7bc36e14d5c7dc0273
  Author: Chris Nardi <cnardi at chromium.org>
  Date:   2023-07-07 (Fri, 07 Jul 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/w3c/test_converter.py
    M Tools/Scripts/webkitpy/w3c/test_converter_unittest.py
    M Tools/Scripts/webkitpy/w3c/test_importer.py

  Log Message:
  -----------
  Do not convert testharness paths in import-w3c-tests
https://bugs.webkit.org/show_bug.cgi?id=185876

Reviewed by Jonathan Bedard.

Since the csswg-tests repo was merged into WPT, there is only one test repository now in
imported/w3c/resources/TestRepositories, which does not specify the option to convert
testharness paths from relative paths to explicit paths. Additionally, wptserve has been
used for some time, so run-webkit-tests should have no problem with relative paths to
the testharness paths. Thus, there is no reason to continue converting testharness paths,
so this patch removes all code related to that conversion.

* Scripts/webkitpy/w3c/test_converter.py:
(convert_for_webkit):
(_W3CTestConverter.__init__):
(_W3CTestConverter.convert_attributes_if_needed):
* Scripts/webkitpy/w3c/test_converter_unittest.py:
(verify_test_harness_paths):
* Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.find_importable_tests):
(TestImporter.import_tests):

Canonical link: https://commits.webkit.org/265842@main




More information about the webkit-changes mailing list