[webkit-changes] [WebKit/WebKit] 0f3437: [run-benchmark] Linux driver executes the browser ...

[Carlos Alberto Lopez Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f3437e25ccfb415fb96a2f1da498a001ad00960
      https://github.com/WebKit/WebKit/commit/0f3437e25ccfb415fb96a2f1da498a001ad00960
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2023-07-07 (Fri, 07 Jul 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py

  Log Message:
  -----------
  [run-benchmark] Linux driver executes the browser capturing stdout/stderr but never checks it
https://bugs.webkit.org/show_bug.cgi?id=258968

Reviewed by Carlos Garcia Campos.

The Linux driver of run-benchmark was capturing stdout and stderr of the
browser subprocess but never checking it. So this caused that when the browser
prints lot of text the pipe gets full and the browser process gets frozen.

This caused timeouts with Cog and the jsbench benchmark. I reported this
originally at https://github.com/Igalia/cog/issues/589 thinking it was a
bug on Cog, but is a bug on the run-benchmark tool.

This patch just changes the way of executing the browser, to not capture stdout
or stderr and just let the browser print the output to the standard stdout/stderr.

* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
(LinuxBrowserDriver.launch_url):

Canonical link: https://commits.webkit.org/265839@main