[webkit-changes] [WebKit/WebKit] 9b4248: CustomElementQueue and CustomElementReactionQueue ...

Ryosuke Niwa noreply at github.com
Thu Jul 6 16:47:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b42484b8e812b6f398f55877d98a5a5845c7270
      https://github.com/WebKit/WebKit/commit/9b42484b8e812b6f398f55877d98a5a5845c7270
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M Source/WebCore/dom/CustomElementReactionQueue.cpp
    M Source/WebCore/dom/CustomElementReactionQueue.h
    M Source/WebCore/dom/GCReachableRef.h

  Log Message:
  -----------
  CustomElementQueue and CustomElementReactionQueue should have an inline capacity
https://bugs.webkit.org/show_bug.cgi?id=258912

Reviewed by Chris Dumez.

Both CustomElementQueue and CustomElementReactionQueue inline capacities of 4 and 1 respectively.

Also moved CustomElementReactionQueueItem from .cpp file to .h file and replaced some payload tuples
with structs to allow forward declarations of Document and HTMLFormElement.

* Source/WebCore/dom/CustomElementReactionQueue.cpp:
(WebCore::CustomElementReactionQueueItem::CustomElementReactionQueueItem):
(WebCore::CustomElementReactionQueueItem::invoke):
(WebCore::CustomElementReactionQueue::enqueueAdoptedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueFormAssociatedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::invokeAll):
(WebCore::CustomElementQueue::takeElements):
(WebCore::CustomElementReactionStack::takeElements):

* Source/WebCore/dom/CustomElementReactionQueue.h:
(WebCore::CustomElementReactionQueueItem): Moved from .cpp file.
(WebCore::CustomElementReactionQueueItem::type const):

* Source/WebCore/dom/GCReachableRef.h:
(WebCore::GCReachableRef::GCReachableRef): Removed the explicit requirement that T must be a subclass
of Node as this would require including Element.h in CustomElementReactionQueue.h. GCReachableRefMap
only supports Node anyway so this check isn't needed.

Canonical link: https://commits.webkit.org/265829@main




More information about the webkit-changes mailing list