[webkit-changes] [WebKit/WebKit] 6caf4c: REGRESSION(264617 at main): fast/forms/ios/file-uploa...

Tim Horton noreply at github.com
Thu Jul 6 14:33:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6caf4c76fb2e97c1be972addb3270dfc4026c18e
      https://github.com/WebKit/WebKit/commit/6caf4c76fb2e97c1be972addb3270dfc4026c18e
  Author: Tim Horton <thorton at apple.com>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm

  Log Message:
  -----------
  REGRESSION(264617 at main): fast/forms/ios/file-upload-panel-accept.html is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=258901
rdar://110879270

Reviewed by Simon Fraser.

* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
The explicit commit introduced in 264617 at main caused multiple bits of unexpected
fallout, breaking a layout test and bypassing commit-coalescing optimizations
in UIKit.

Instead of explicitly committing, just hold on to the IOSurface ports until
the commit arrives in the render server. (We can't hold on to the whole
transaction because the ports are consumed when applying the backing store
to its layer).

Canonical link: https://commits.webkit.org/265825@main




More information about the webkit-changes mailing list