[webkit-changes] [WebKit/WebKit] 8e07bf: [Cocoa] Special case isTypeSupported("...codecs=op...

Jer Noble noreply at github.com
Thu Jul 6 10:20:56 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e07bf03ac887b0d5da4df918c83e49e2c3cb9a8
      https://github.com/WebKit/WebKit/commit/8e07bf03ac887b0d5da4df918c83e49e2c3cb9a8
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M Source/WebCore/PAL/pal/cf/AudioToolboxSoftLink.cpp
    M Source/WebCore/PAL/pal/cf/AudioToolboxSoftLink.h
    M Source/WebCore/PAL/pal/spi/cocoa/AudioToolboxSPI.h
    M Source/WebCore/platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm

  Log Message:
  -----------
  [Cocoa] Special case isTypeSupported("...codecs=opus")
https://bugs.webkit.org/show_bug.cgi?id=258906
rdar://109483454

Reviewed by Eric Carlson.

Do not report that ISO BMFF files containing Opus audio contents are playable
if the system does not support multichannel decoding of Opus media. Otherwise
sites will preferentially send "video/mp4 codecs=opus" content to WebKit and
be surprised when playback fails.

* Source/WebCore/PAL/pal/cf/AudioToolboxSoftLink.cpp:
* Source/WebCore/PAL/pal/cf/AudioToolboxSoftLink.h:
* Source/WebCore/PAL/pal/spi/cocoa/AudioToolboxSPI.h:
* Source/WebCore/platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm:
(WebCore::isMultichannelOpusAvailable):
(WebCore::AVAssetMIMETypeCache::canDecodeExtendedType):

Canonical link: https://commits.webkit.org/265813@main




More information about the webkit-changes mailing list