[webkit-changes] [WebKit/WebKit] 1e1eec: Use WebSQLiteDatabaseTracker on macOS

bnham noreply at github.com
Wed Jul 5 22:08:36 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e1eecdaf27e6553420e54784ac402e3ff01c1b3
      https://github.com/WebKit/WebKit/commit/1e1eecdaf27e6553420e54784ac402e3ff01c1b3
  Author: Ben Nham <nham at apple.com>
  Date:   2023-07-05 (Wed, 05 Jul 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkProcess.h
    M Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm
    M Source/WebKit/WebProcess/WebProcess.cpp
    M Source/WebKit/WebProcess/WebProcess.h

  Log Message:
  -----------
  Use WebSQLiteDatabaseTracker on macOS
https://bugs.webkit.org/show_bug.cgi?id=258905
rdar://111816429

Reviewed by Chris Dumez and Alex Christensen.

Previously we only used WebSQLiteDatabaseTracker on iOS. This meant that on macOS versions where
process suspension is enabled, NetworkProcess could get suspended while holding a locked file
(generally an advisory file lock on a SQLite database), triggering the locked files killer. To fix
this, enable WebSQLiteDatabaseTracker on macOS too.

* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::setIsHoldingLockedFiles):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm:
(WebKit::NetworkProcess::setIsHoldingLockedFiles): Deleted.
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::prepareToSuspend):
(WebKit::WebProcess::processDidResume):
* Source/WebKit/WebProcess/WebProcess.h:

Canonical link: https://commits.webkit.org/265791@main




More information about the webkit-changes mailing list