[webkit-changes] [WebKit/WebKit] 303365: Simplify <attachment> wide layout CSS

Tim Nguyen noreply at github.com
Wed Jul 5 14:29:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 303365687301f3351c19f44acb5ee56f41b4ab81
      https://github.com/WebKit/WebKit/commit/303365687301f3351c19f44acb5ee56f41b4ab81
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-07-05 (Wed, 05 Jul 2023)

  Changed paths:
    M LayoutTests/fast/attachment/mac/wide-attachment-image-controls-basic-expected.txt
    M LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    M LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    M Source/WebCore/html/shadow/attachmentElementShadow.css

  Log Message:
  -----------
  Simplify <attachment> wide layout CSS
https://bugs.webkit.org/show_bug.cgi?id=258842
rdar://111719672

Reviewed by Wenson Hsieh.

- Use less hardcoded dimensions and write them in terms of HI spec dimensions
- Make top level container use flexbox (since it doesn't need grid)
- Share more code

* LayoutTests/fast/attachment/mac/wide-attachment-image-controls-basic-expected.txt:
* LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* Source/WebCore/html/shadow/attachmentElementShadow.css:
(div#attachment-container):
(div#attachment-preview-area):
(img#attachment-icon):
(div#attachment-placeholder,):
(div#attachment-placeholder):
(div#attachment-progress):
(div#attachment-information-area):
(div#attachment-information-block):

Canonical link: https://commits.webkit.org/265782@main




More information about the webkit-changes mailing list