[webkit-changes] [WebKit/WebKit] 7ca70a: [WPE][GTK] API test `TestWebProcessExtensions` `/w...

Vitaly Dyachkov noreply at github.com
Wed Jul 5 10:45:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7ca70abf650fc5c8a319d6a7cc2c982d90dcf0ba
      https://github.com/WebKit/WebKit/commit/7ca70abf650fc5c8a319d6a7cc2c982d90dcf0ba
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-07-05 (Wed, 05 Jul 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebProcessExtensions.cpp
    M Tools/TestWebKitAPI/glib/TestExpectations.json

  Log Message:
  -----------
  [WPE][GTK] API test `TestWebProcessExtensions` `/webkit/WebKitWebProcessExtension/user-messages` is flaky
https://bugs.webkit.org/show_bug.cgi?id=258883

Reviewed by Philippe Normand.

As explained in `190570 at main`, on GTK `webkit_web_view_new` returns
a floating reference, where on WPE it returns an ordinary reference.
There is a special function - `Test::adoptView()` which allows us
not worry about this difference.

Also, this test does a lot of async stuff and can be slow,
so marking it as "slow".

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebProcessExtensions.cpp:
(testWebProcessExtensionUserMessages):
* Tools/TestWebKitAPI/glib/TestExpectations.json:

Canonical link: https://commits.webkit.org/265772@main




More information about the webkit-changes mailing list