[webkit-changes] [WebKit/WebKit] a4a7ff: Focused text form controls should not get an Inter...

Etienne Segonzac noreply at github.com
Wed Jul 5 02:12:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4a7ff9eae45b43802428aa8b520f7c884ad62da
      https://github.com/WebKit/WebKit/commit/a4a7ff9eae45b43802428aa8b520f7c884ad62da
  Author: Etienne Segonzac <sgz at apple.com>
  Date:   2023-07-05 (Wed, 05 Jul 2023)

  Changed paths:
    A LayoutTests/interaction-region/text-controls-expected.txt
    A LayoutTests/interaction-region/text-controls.html
    A LayoutTests/interaction-region/text-input-focused-expected.txt
    A LayoutTests/interaction-region/text-input-focused.html
    A LayoutTests/interaction-region/textarea-focused-expected.txt
    A LayoutTests/interaction-region/textarea-focused.html
    M Source/WebCore/page/InteractionRegion.cpp

  Log Message:
  -----------
  Focused text form controls should not get an Interaction Region
https://bugs.webkit.org/show_bug.cgi?id=258852
<rdar://111156944>

Reviewed by Tim Nguyen.

All `HTMLFormControlElement` get an InteractionRegion. For
`HTMLTextFormControlElement`, add a check to make sure they're not
currently focused.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::shouldAllowNonPointerCursorForElement):
Add the check.

* LayoutTests/interaction-region/text-controls-expected.txt: Added.
* LayoutTests/interaction-region/text-controls.html: Added.
* LayoutTests/interaction-region/text-input-focused-expected.txt: Added.
* LayoutTests/interaction-region/text-input-focused.html: Added.
* LayoutTests/interaction-region/textarea-focused-expected.txt: Added.
* LayoutTests/interaction-region/textarea-focused.html: Added.
New tests covering the change.

Canonical link: https://commits.webkit.org/265764@main




More information about the webkit-changes mailing list