[webkit-changes] [WebKit/WebKit] 40df48: Add additional assertions to InlineCacheCompiler
Justin Michaud
noreply at github.com
Tue Jul 4 12:28:16 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 40df48799883c603be2823a3c86c2172ecb4ef8d
https://github.com/WebKit/WebKit/commit/40df48799883c603be2823a3c86c2172ecb4ef8d
Author: Justin Michaud <justin_michaud at apple.com>
Date: 2023-07-04 (Tue, 04 Jul 2023)
Changed paths:
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h
M Source/JavaScriptCore/jit/RegisterSet.h
Log Message:
-----------
Add additional assertions to InlineCacheCompiler
rdar://110382994
Reviewed by Mark Lam.
We are sometimes finding ourselves in an inconsistent state where
we have allocated stack space but have no live registers to preserve.
Let's add some additional assertions to make it easier to find the root cause.
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::InlineCacheCompiler::preserveLiveRegistersToStackForCall):
(JSC::InlineCacheCompiler::preserveLiveRegistersToStackForCallWithoutExceptions):
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.h:
(JSC::InlineCacheCompiler::setSpillStateForJSCall):
(JSC::InlineCacheCompiler::spillStateForJSCall const):
Canonical link: https://commits.webkit.org/265759@main
More information about the webkit-changes
mailing list