[webkit-changes] [WebKit/WebKit] e8d22b: Make <attachment> progress circle use a single ele...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e8d22b587bfc47267c9c14a47c5a76f8d843c0e8
      https://github.com/WebKit/WebKit/commit/e8d22b587bfc47267c9c14a47c5a76f8d843c0e8
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-07-04 (Tue, 04 Jul 2023)

  Changed paths:
    M LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    M LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    M Source/WebCore/html/HTMLAttachmentElement.cpp
    M Source/WebCore/html/shadow/attachmentElementShadow.css

  Log Message:
  -----------
  Make <attachment> progress circle use a single element
https://bugs.webkit.org/show_bug.cgi?id=258840
rdar://111719618

Reviewed by Antti Koivisto.

Use a pseudo-element (::before) to avoid needing to create a separate element in the DOM.

* LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::ensureWideLayoutShadowTree):
(WebCore::attachmentProgressCircleIdentifier): Deleted.
* Source/WebCore/html/shadow/attachmentElementShadow.css:
(div#attachment-progress::before):
(div#attachment-progress-circle): Deleted.

Canonical link: https://commits.webkit.org/265749@main