[webkit-changes] [WebKit/WebKit] aede64: Media Controls: Interaction region on visionOS <au...

Richard Robinson noreply at github.com
Mon Jul 3 17:01:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aede64d8b36a0d1dd1b138674a497ee2f2ba378d
      https://github.com/WebKit/WebKit/commit/aede64d8b36a0d1dd1b138674a497ee2f2ba378d
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-07-03 (Mon, 03 Jul 2023)

  Changed paths:
    M Source/WebCore/Modules/modern-media-controls/controls/vision-media-controls.css

  Log Message:
  -----------
  Media Controls: Interaction region on visionOS <audio> volume button is too big
https://bugs.webkit.org/show_bug.cgi?id=258772
rdar://110499146

Reviewed by Tim Horton.

The existing padding and margins of the media control bar buttons were designed for button and bar
sizes of the <video> element, which are larger than those of the <audio> element. This caused the
interaction regions of all the audio control bar buttons to be larger than they should.

Fix by reducing the padding to compensate and match the ratio of the <video> buttons' padding, and
adjust the margins to maintain concentricity with the controls bar.

* Source/WebCore/Modules/modern-media-controls/controls/vision-media-controls.css:
(.media-controls.vision.audio > .bottom.controls-bar,):
(.media-controls.vision.audio > .bottom.controls-bar button):
(.media-controls.vision.audio > .bottom.controls-bar button.mute):
(.media-controls.vision.audio > .bottom.controls-bar .buttons-container.left):
(.media-controls.vision.audio > .bottom.controls-bar .buttons-container.right):

Canonical link: https://commits.webkit.org/265739@main




More information about the webkit-changes mailing list