[webkit-changes] [WebKit/WebKit] 660682: Connection::sendSyncMessage changes NoError to Uns...

[Gerald Squelart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 660682ad1542a3213cf4bdfb75c433a52faa0630
      https://github.com/WebKit/WebKit/commit/660682ad1542a3213cf4bdfb75c433a52faa0630
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2023-07-03 (Mon, 03 Jul 2023)

  Changed paths:
    M Source/WebKit/Platform/IPC/Connection.cpp

  Log Message:
  -----------
  Connection::sendSyncMessage changes NoError to Unspecified if there is no decoder
https://bugs.webkit.org/show_bug.cgi?id=258793
rdar://111444264

Reviewed by Kimmo Kinnunen.

If sendSyncMessage return a null decoder along with NoError, callers may think the call succeeded and try to access the return value, which is actually an empty optional.

* Source/WebKit/Platform/IPC/Connection.cpp:
(IPC::Connection::sendSyncMessage):

Canonical link: https://commits.webkit.org/265736@main