[webkit-changes] [WebKit/WebKit] d131b5: [visionOS] Hide ornaments when entering fullscreen

Aditya Keerthi noreply at github.com
Mon Jul 3 13:56:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d131b55339dfc87378ccda0140cee339e31b242b
      https://github.com/WebKit/WebKit/commit/d131b55339dfc87378ccda0140cee339e31b242b
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-07-03 (Mon, 03 Jul 2023)

  Changed paths:
    M Source/WebKit/Platform/spi/visionos/MRUIKitSPI.h
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm

  Log Message:
  -----------
  [visionOS] Hide ornaments when entering fullscreen
https://bugs.webkit.org/show_bug.cgi?id=258786
rdar://111453364

Reviewed by Tim Horton.

Ornaments are smaller pieces of UI associated with a particular window scene.
When performing the fullscreen transition, these pieces of UI should be hidden
alongside the presenting window.

* Source/WebKit/Platform/spi/visionos/MRUIKitSPI.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenParentWindowState initWithWindow:]):

Store the original depth of ornaments to restore their depth after exiting fullscreen.

(-[WKFullScreenParentWindowState ornamentDepths]):
(-[WKFullScreenWindowController _performSpatialFullScreenTransition:completionHandler:]):

Animate the ornaments as if they were a part of the presenting window, matching
the fade and depth animations.

Canonical link: https://commits.webkit.org/265733@main




More information about the webkit-changes mailing list