[webkit-changes] [WebKit/WebKit] 852182: Spell checking indicator shows when an inline pred...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8521823072e7874f26ca06f742185dae605316d0
      https://github.com/WebKit/WebKit/commit/8521823072e7874f26ca06f742185dae605316d0
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-07-03 (Mon, 03 Jul 2023)

  Changed paths:
    M Source/WebCore/editing/Editor.cpp
    M Tools/TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm

  Log Message:
  -----------
  Spell checking indicator shows when an inline prediction candidate for a proper noun is being shown
https://bugs.webkit.org/show_bug.cgi?id=258643
rdar://110196591

Reviewed by Wenson Hsieh.

Use the `m_isHandlingAcceptedCandidate` flag to indicate when an inline prediction candidate is
being offered.

Setting text via `setMarkedText` eventually gets into `Editor::markAllMisspellingsAndBadGrammarInRanges`,
so exit early in that method if the flag is set so that spelling and grammer checking does not get
erroneously applied.

* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::setComposition):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
* Tools/TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm:
(TEST):

Canonical link: https://commits.webkit.org/265725@main