[webkit-changes] [WebKit/WebKit] b09b24: [WPE][GTK] API test `TestWebKitWebView` `/webkit/W...

Vitaly Dyachkov noreply at github.com
Mon Jul 3 10:15:21 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b09b2477ece478964e92ba3323d5a19e278feaed
      https://github.com/WebKit/WebKit/commit/b09b2477ece478964e92ba3323d5a19e278feaed
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-07-03 (Mon, 03 Jul 2023)

  Changed paths:
    M Tools/TestWebKitAPI/glib/TestExpectations.json

  Log Message:
  -----------
  [WPE][GTK] API test `TestWebKitWebView` `/webkit/WebKitWebView/is-web-process-responsive` is a timeout
https://bugs.webkit.org/show_bug.cgi?id=258810

Reviewed by Michael Catanzaro.

In this test, we wait several times for some events to occur:

1. Wait for the first page to finish loading.
2. Wait one second for JS loop to start executing.
3. Wait until the web process becomes unresponsive.
4. Wait for the second page to finish loading.

The responsive timer alone takes at least 3 seconds to detect that page
is unresponsive.

Altogether can easily exceed the default 5 seconds threshold for
`run-wpe-test` to mark the tests as a timeout.

The same applies to
`/webkit/WebKitWebView/terminate-unresponsive-web-process` test.

Marking these tests as `slow` gives ten times more time for the tests
to finish, which should be more than enough.

* Tools/TestWebKitAPI/glib/TestExpectations.json:

Canonical link: https://commits.webkit.org/265723@main




More information about the webkit-changes mailing list