[webkit-changes] [WebKit/WebKit] a816d2: [FFC] Add support for align-self: stretch

Alan Baradlay noreply at github.com
Mon Jul 3 09:22:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a816d2cae2d2e2591c6b63a2757aa3b5e4a01832
      https://github.com/WebKit/WebKit/commit/a816d2cae2d2e2591c6b63a2757aa3b5e4a01832
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-07-03 (Mon, 03 Jul 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexLayout.h
    M Source/WebCore/layout/formattingContexts/flex/LogicalFlexItem.h

  Log Message:
  -----------
  [FFC] Add support for align-self: stretch
https://bugs.webkit.org/show_bug.cgi?id=258790

Reviewed by Antti Koivisto.

Here the used value is the length necessary to make the cross size of the item's margin box
as close to the same size as the line as possible, while still respecting
the constraints imposed by min-height/min-width/max-height/max-width.

(Sadly it also means handleCrossAxisAlignmentForFlexItems now may mutate the cross _size_ of a flex item)

* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::handleCrossAxisAlignmentForFlexItems const):
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:
* Source/WebCore/layout/formattingContexts/flex/LogicalFlexItem.h:

Canonical link: https://commits.webkit.org/265721@main




More information about the webkit-changes mailing list