[webkit-changes] [WebKit/WebKit] 2c7aad: TestIPC.StreamMessageTest.SendAsyncReplyCancel fai...

Kimmo Kinnunen noreply at github.com
Mon Jul 3 04:27:03 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2c7aad7e72e9b1c12b444fb99251b11f7a70d790
      https://github.com/WebKit/WebKit/commit/2c7aad7e72e9b1c12b444fb99251b11f7a70d790
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-07-03 (Mon, 03 Jul 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp

  Log Message:
  -----------
  TestIPC.StreamMessageTest.SendAsyncReplyCancel fails in ASAN builds
https://bugs.webkit.org/show_bug.cgi?id=258717
rdar://111558108

Reviewed by Simon Fraser.

Fix the failure in the test implementation. The local variable
`workQueueWait` would be destroyed before local reference barrier
`cleanup` would ensure that no pending work is in the server work queue.

The local reference barriers should be constructed after the locals
being protected.

* Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp:
(TestWebKitAPI::TEST_P):

Canonical link: https://commits.webkit.org/265710@main




More information about the webkit-changes mailing list