[webkit-changes] [WebKit/WebKit] 4fdb80: [WPE][GTK] API test `WebKit.PrivateBrowsingPushSta...

Vitaly Dyachkov noreply at github.com
Mon Jul 3 01:19:43 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4fdb80d3008b30d5e6458c972763e57804e0b851
      https://github.com/WebKit/WebKit/commit/4fdb80d3008b30d5e6458c972763e57804e0b851
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-07-03 (Mon, 03 Jul 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp
    M Tools/TestWebKitAPI/glib/TestExpectations.json

  Log Message:
  -----------
  [WPE][GTK] API test `WebKit.PrivateBrowsingPushStateNoHistoryCallback` is a timeout
https://bugs.webkit.org/show_bug.cgi?id=258721

Reviewed by Michael Catanzaro.

`FrameLoader::HistoryController` won't update global history and notify
its client that it `didNavigateWithNavigationData()` when
`usesEphemeralSession()`.

On WPE and GTK `WKWebsiteDataStoreGetDefaultDataStore()` by default
creates a data store with an ephemeral session id.

To fix it, we must explicitly create and use a non-ephemeral data store.

* Tools/TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/glib/TestExpectations.json:

Canonical link: https://commits.webkit.org/265707@main




More information about the webkit-changes mailing list