[webkit-changes] [WebKit/WebKit] 78b414: ScrollerMac shouldn't use hardcoded NSControlSize

Luke Warlow noreply at github.com
Sat Jul 1 16:51:18 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 78b4149d570a3d45b62b4d6312c7692d2f7f18e4
      https://github.com/WebKit/WebKit/commit/78b4149d570a3d45b62b4d6312c7692d2f7f18e4
  Author: Luke Warlow <luke at warlow.dev>
  Date:   2023-07-01 (Sat, 01 Jul 2023)

  Changed paths:
    M Source/WebCore/page/scrolling/mac/ScrollerMac.mm
    M Source/WebCore/page/scrolling/mac/ScrollerPairMac.h
    M Source/WebCore/page/scrolling/mac/ScrollerPairMac.mm
    M Source/WebCore/platform/mac/ScrollTypesMac.h
    M Source/WebCore/platform/mac/ScrollbarThemeMac.mm

  Log Message:
  -----------
  ScrollerMac shouldn't use hardcoded NSControlSize
https://bugs.webkit.org/show_bug.cgi?id=258752

Reviewed by Simon Fraser.

This patch moves the function to convert from ScrollbarWidth to NSControlSize into ScrollTypesMac.h.
This is then used inside of ScrollerMac instead of a hard coded NSControlSizeRegular.
ScrollerPairMac currently returns a hardcoded ScrollbarWidth::Auto, so this patch has no behaviour changes.

* Source/WebCore/page/scrolling/mac/ScrollerMac.mm:
(WebCore::ScrollerMac::attach):
(WebCore::ScrollerMac::updateScrollbarStyle):
* Source/WebCore/page/scrolling/mac/ScrollerPairMac.h:
* Source/WebCore/page/scrolling/mac/ScrollerPairMac.mm:
(WebCore::ScrollerPairMac::scrollbarWidthStyle const):
* Source/WebCore/platform/mac/ScrollTypesMac.h:
(WebCore::nsControlSizeFromScrollbarWidth):
* Source/WebCore/platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::scrollbarWidthToNSControlSize): Deleted.

Canonical link: https://commits.webkit.org/265691@main




More information about the webkit-changes mailing list