[webkit-changes] [WebKit/WebKit] a58629: [GPU Process] [FormControls] Add a ControlPart for...

Said Abou-Hallawa noreply at github.com
Tue Jan 31 17:12:54 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a586299ede2ec5ded2e1d4495c5b743e2a696540
      https://github.com/WebKit/WebKit/commit/a586299ede2ec5ded2e1d4495c5b743e2a696540
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-01-31 (Tue, 31 Jan 2023)

  Changed paths:
    M Source/WebCore/Sources.txt
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/editing/FontAttributeChanges.h
    A Source/WebCore/platform/graphics/cocoa/controls/ApplePayButtonCocoa.h
    A Source/WebCore/platform/graphics/cocoa/controls/ApplePayButtonCocoa.mm
    A Source/WebCore/platform/graphics/cocoa/controls/ControlFactoryCocoa.h
    A Source/WebCore/platform/graphics/cocoa/controls/ControlFactoryCocoa.mm
    A Source/WebCore/platform/graphics/controls/ApplePayButtonPart.cpp
    A Source/WebCore/platform/graphics/controls/ApplePayButtonPart.h
    M Source/WebCore/platform/graphics/controls/ControlFactory.h
    M Source/WebCore/platform/graphics/mac/AppKitControlSystemImage.h
    M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h
    M Source/WebCore/platform/graphics/mac/controls/ImageControlsButtonMac.mm
    M Source/WebCore/platform/graphics/mac/controls/SearchFieldCancelButtonMac.mm
    M Source/WebCore/platform/graphics/mac/controls/SearchFieldMac.mm
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/rendering/RenderThemeMac.mm
    M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  [GPU Process] [FormControls] Add a ControlPart for ApplePayButton
https://bugs.webkit.org/show_bug.cgi?id=251416
rdar://104850550

Reviewed by Aditya Keerthi.

Treat ApplePayButton as a ControlPart and draw it through GraphicsContext::drawControlPart().
Remove the special case for drawing the ApplePayButton as a SystemImage.

* Source/WebCore/Sources.txt:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/editing/FontAttributeChanges.h:
* Source/WebCore/platform/graphics/cocoa/controls/ApplePayButtonCocoa.h: Added.
* Source/WebCore/platform/graphics/cocoa/controls/ApplePayButtonCocoa.mm: Copied from Source/WebCore/platform/graphics/mac/controls/ImageControlsButtonMac.mm.
(WebCore::ApplePayButtonCocoa::ApplePayButtonCocoa):
(WebCore::ApplePayButtonCocoa::draw):
* Source/WebCore/platform/graphics/cocoa/controls/ControlFactoryCocoa.h: Added.
* Source/WebCore/platform/graphics/cocoa/controls/ControlFactoryCocoa.mm: Copied from Source/WebCore/platform/graphics/mac/controls/ImageControlsButtonMac.mm.
(WebCore::ControlFactoryCocoa::createPlatformApplePayButton):
* Source/WebCore/platform/graphics/controls/ApplePayButtonPart.cpp: Added.
(WebCore::ApplePayButtonPart::create):
(WebCore::ApplePayButtonPart::ApplePayButtonPart):
(WebCore::ApplePayButtonPart::createPlatformControl):
* Source/WebCore/platform/graphics/controls/ApplePayButtonPart.h: Added.
(WebCore::ApplePayButtonPart::buttonType const):
(WebCore::ApplePayButtonPart::buttonStyle const):
(WebCore::ApplePayButtonPart::locale const):
* Source/WebCore/platform/graphics/controls/ControlFactory.h:
* Source/WebCore/platform/graphics/mac/AppKitControlSystemImage.h:
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h:
* Source/WebCore/platform/graphics/mac/controls/ImageControlsButtonMac.mm:
* Source/WebCore/platform/graphics/mac/controls/SearchFieldCancelButtonMac.mm:
* Source/WebCore/platform/graphics/mac/controls/SearchFieldMac.mm:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::createApplePayButtonPartForRenderer):
(WebCore::RenderTheme::createControlPart const):
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::canCreateControlPartForRenderer const):
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ControlPart>::encode):
(IPC::ArgumentCoder<ControlPart>::decode):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/259652@main




More information about the webkit-changes mailing list