[webkit-changes] [WebKit/WebKit] a33428: fast/forms/ios/input-peripherals-with-validation-m...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a33428d63fdb18d6287d48c6ab8c9bbdda84b30d
      https://github.com/WebKit/WebKit/commit/a33428d63fdb18d6287d48c6ab8c9bbdda84b30d
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-01-31 (Tue, 31 Jan 2023)

  Changed paths:
    M LayoutTests/fast/forms/ios/input-peripherals-with-validation-message.html

  Log Message:
  -----------
  fast/forms/ios/input-peripherals-with-validation-message.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=251445
rdar://104760120

Reviewed by Wenson Hsieh.

Form controls with validation constraints display a validation bubble if their
contents do not satisfy the constraints when attempting submission. The
"input-peripherals-with-validation-message.html" test verifies that validation
bubbles and input peripherals (such as date pickers) are not presented at the
same time.

If the position of a form control changes the validation bubble is automatically
dismissed. This logic is run as an asynchronous task following layout, which
then dispatches IPC to the UIProcess to perform dismissal.

Prior to verifying whether the validation bubble is visible, the test verifies
the document's focused element with a call to `shouldBe`. This verification
adds text to the DOM, moving the form control (date input) down, and initiating
dismissal of the validation bubble. Next, the test checks the visibility of the
validation bubble. Recent changes in UIKit introduced an additional delay when
presenting a popover, resulting in the post-layout tasks completing before
presentation, hiding the bubble. This is expected behavior, as the bubble should
be dismissed due to layout changes.

To fix, move the checks for the document's focused element after allowing the
bubble to be presented.

* LayoutTests/fast/forms/ios/input-peripherals-with-validation-message.html:

Canonical link: https://commits.webkit.org/259647@main