[webkit-changes] [WebKit/WebKit] 288bbe: Use a different layer border color with UI-side co...

Simon Fraser noreply at github.com
Tue Jan 31 11:06:44 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 288bbe866276cd5fadbc9a5eef57e6346c26060d
      https://github.com/WebKit/WebKit/commit/288bbe866276cd5fadbc9a5eef57e6346c26060d
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-01-31 (Tue, 31 Jan 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
    M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h
    M Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.h
    M Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.mm

  Log Message:
  -----------
  Use a different layer border color with UI-side compositing
https://bugs.webkit.org/show_bug.cgi?id=251406
<rdar://problem/104844082>

Reviewed by Sam Weinig and Tim Horton.

The value returned by GraphicsLayerCA::pageTiledBackingBorderColor() will be the legacy page tile
border color once UI-side compositing is enabled by default. Change it to something more navy/gray,
so that it can be distinguished from the UI-side compositing colors in screenshots.

Also do a drive-by fix where the RemoteLayerTreeDrawingArea "root" layer should not get
sized to the contents size on macOS, where we don't delegate scrolling to a native view.

* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::pageTiledBackingBorderColor const):
(WebCore::GraphicsLayerCA::getDebugBorderInfo const):
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp:
(WebKit::GraphicsLayerCARemote::pageTiledBackingBorderColor const):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h:
* Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.h:
* Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.mm:
(WebKit::RemoteLayerTreeDrawingAreaMac::mainFrameContentSizeChanged):

Canonical link: https://commits.webkit.org/259637@main




More information about the webkit-changes mailing list