[webkit-changes] [WebKit/WebKit] 9de2e8: [web-animations] use the keyframe's StylePropertie...

Antoine Quint noreply at github.com
Tue Jan 31 08:35:22 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9de2e80cf70bba0c043026bf9e1119a43dd8e0bf
      https://github.com/WebKit/WebKit/commit/9de2e80cf70bba0c043026bf9e1119a43dd8e0bf
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-01-31 (Tue, 31 Jan 2023)

  Changed paths:
    M Source/WebCore/animation/KeyframeEffect.cpp

  Log Message:
  -----------
  [web-animations] use the keyframe's StyleProperties to determine whether a property is set to "inherit" in a keyframe
https://bugs.webkit.org/show_bug.cgi?id=251432

Reviewed by Antti Koivisto.

Until now we would determine whether a property is set to "inherit" in a keyframe by doing a string
comparison when the Web Animations API is used to set keyframes. However, the StyleRuleKeyframe
created for the keyframe has StyleProperties where the value is parsed, it seems safer to check
the CSSValue rather than do a string comparison here.

* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::processKeyframes):
(WebCore::KeyframeEffect::updateBlendingKeyframes):

Canonical link: https://commits.webkit.org/259630@main




More information about the webkit-changes mailing list