[webkit-changes] [WebKit/WebKit] d2ccfc: [WGSL] Minor improvements to MetalFunctionWriter

Tadeu Zagallo noreply at github.com
Tue Jan 31 02:56:23 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d2ccfc205f0c7d006240466c1321ccc0a063fd45
      https://github.com/WebKit/WebKit/commit/d2ccfc205f0c7d006240466c1321ccc0a063fd45
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-01-31 (Tue, 31 Jan 2023)

  Changed paths:
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

  Log Message:
  -----------
  [WGSL] Minor improvements to MetalFunctionWriter
https://bugs.webkit.org/show_bug.cgi?id=251365
rdar://104821399

Reviewed by Myles C. Maxfield.

This PR combines a few tiny changes to MetalFunctionWriter as we work
towards supporting compute shaders. Namely:
1. Serialize `void` return types
2. Serialize the `global_invocation_id` builtin
3. Serialize `uint32` literals
4. Only use the buffer index calculation function for vertex shaders

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
(WGSL::Metal::FunctionDefinitionWriter::visitArgumentBufferParameter):

Canonical link: https://commits.webkit.org/259622@main




More information about the webkit-changes mailing list