[webkit-changes] [WebKit/WebKit] df25b4: Hairline on selection when bidi text is involved

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: df25b495844dd7ecb0314c4c42c318088bf0c863
      https://github.com/WebKit/WebKit/commit/df25b495844dd7ecb0314c4c42c318088bf0c863
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-01-29 (Sun, 29 Jan 2023)

  Changed paths:
    A LayoutTests/fast/repaint/rtl-content-selection-hairline-gap-expected.txt
    A LayoutTests/fast/repaint/rtl-content-selection-hairline-gap.html
    M Source/WebCore/rendering/TextBoxPainter.cpp

  Log Message:
  -----------
  Hairline on selection when bidi text is involved
https://bugs.webkit.org/show_bug.cgi?id=220548
<rdar://problem/73362060>

Reviewed by Antti Koivisto.

Due to webkit.org/b/251318, we may compute a slightly shorter selection rect for non-whitespace runs with soft wrap opportunities between them.
Such shrunk selection rects produce hairline gap at inline box boundaries.

* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter<TextBoxPath>::paintBackground): we've got _visual_ values here (at least with ignoring writing-mode), no need for directional pixel snapping.

Canonical link: https://commits.webkit.org/259537@main