[webkit-changes] [WebKit/WebKit] 91955d: [GTK][WPE] Bring back WebKitConsoleMessage API imp...

Carlos Garcia Campos noreply at github.com
Sun Jan 29 01:05:46 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 91955d0ab066432662bddfc48d7d6b9388aec222
      https://github.com/WebKit/WebKit/commit/91955d0ab066432662bddfc48d7d6b9388aec222
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-01-29 (Sun, 29 Jan 2023)

  Changed paths:
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp
    A Tools/TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp
    M Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp
    M Tools/TestWebKitAPI/glib/CMakeLists.txt

  Log Message:
  -----------
  [GTK][WPE] Bring back WebKitConsoleMessage API implementation
https://bugs.webkit.org/show_bug.cgi?id=251315

Reviewed by Michael Catanzaro.

I deprecated the API in 257010 at main and removed the functionality
assuming nobody was actually using it, but I was wrong. So, keep the API
deprecated, but bring back the implementation for backwards
compatibility.

* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:
(webkitWebPageDidSendConsoleMessage):
(webkit_web_page_class_init):
(webkitWebPageCreate):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Added.
(ConsoleMessageTest::ConsoleMessage::operator== const):
(ConsoleMessageTest::consoleMessageReceivedCallback):
(ConsoleMessageTest::ConsoleMessageTest):
(ConsoleMessageTest::~ConsoleMessageTest):
(ConsoleMessageTest::waitUntilConsoleMessageReceived):
(testWebKitConsoleMessageConsoleAPI):
(testWebKitConsoleMessageJavaScriptException):
(testWebKitConsoleMessageNetworkError):
(testWebKitConsoleMessageSecurityError):
(beforeAll):
(afterAll):
* Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
(consoleMessageSentCallback):
(pageCreatedCallback):
* Tools/TestWebKitAPI/glib/CMakeLists.txt:

Canonical link: https://commits.webkit.org/259535@main




More information about the webkit-changes mailing list