[webkit-changes] [WebKit/WebKit] 275b52: Add WKApplicationManifest API

Brady Eidson noreply at github.com
Fri Jan 27 22:27:26 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 275b520c94280c07ae81e2769ae4f71a6c1e301b
      https://github.com/WebKit/WebKit/commit/275b520c94280c07ae81e2769ae4f71a6c1e301b
  Author: Brady Eidson <beidson at apple.com>
  Date:   2023-01-27 (Fri, 27 Jan 2023)

  Changed paths:
    M Source/WebKit/SourcesCocoa.txt
    A Source/WebKit/UIProcess/API/Cocoa/WKApplicationManifest.h
    A Source/WebKit/UIProcess/API/Cocoa/WKApplicationManifest.mm
    A Source/WebKit/UIProcess/API/Cocoa/WKApplicationManifestInternal.h
    A Source/WebKit/UIProcess/API/Cocoa/WKApplicationManifestPrivate.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKInspectorInternal.h
    M Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm

  Log Message:
  -----------
  Add WKApplicationManifest API
https://bugs.webkit.org/show_bug.cgi?id=251298
rdar://104630943

Reviewed by Andy Estes.

WKApplicationManifest directly reflects how the _WKApplicationManifest SPI works, but with a few differences:
1 - It is not constructible by the API client, only accessible from a WKWebView instance
2 - API-wise it is an opaque token, instead of having accessible properties
3 - It will have more private properties added to it in a followup patch that _WKApplicationManifest doesn't need

So I'm creating a new object instead of just promoting the older SPI.

* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/Cocoa/WKApplicationManifest.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKInspectorInternal.h.
* Source/WebKit/UIProcess/API/Cocoa/WKApplicationManifest.mm: Added.
(-[WKApplicationManifest _apiObject]):
(-[WKApplicationManifest initWithApplicationManifest:]):
(nullableNSString):
(-[WKApplicationManifest _name]):
(-[WKApplicationManifest _shortName]):
(-[WKApplicationManifest _applicationDescription]):
(-[WKApplicationManifest _scope]):
(-[WKApplicationManifest _startURL]):
(-[WKApplicationManifest _themeColor]):
(-[WKApplicationManifest _displayMode]):
(-[WKApplicationManifest _icons]):
(-[WKApplicationManifest _manifestId]):
* Source/WebKit/UIProcess/API/Cocoa/WKApplicationManifestInternal.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKInspectorInternal.h.
* Source/WebKit/UIProcess/API/Cocoa/WKApplicationManifestPrivate.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKInspectorInternal.h.
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView getApplicationManifestWithCompletionHandler:]):
* Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm:
* Source/WebKit/UIProcess/API/Cocoa/_WKInspectorInternal.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/259523@main




More information about the webkit-changes mailing list